]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(...
authorAuke Kok <auke-jan.h.kok@intel.com>
Mon, 21 May 2007 21:51:35 +0000 (14:51 -0700)
committerJeff Garzik <jeff@garzik.org>
Mon, 21 May 2007 23:41:19 +0000 (19:41 -0400)
commit3e1657c8ef53e1cd541cc1e420f3230dc075949b
tree7761c899ea09c104324fa333d75dc1e31cf70255
parent8aee74c8ee875448cc6d1cf995c9469eb60ae515
e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

Herbert Xu wrote:
"netif_poll_enable can only be called if you've previously called
netif_poll_disable.  Otherwise a poll might already be in action
and you may get a crash like this."

Removing the call to netif_poll_enable in e1000_open should fix this issue,
the only other call to netif_poll_enable is in e1000_up() which is only
reached after a device reset or resume.

Bugzilla: http://bugzilla.kernel.org/show_bug.cgi?id=8455
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240339

Tested by Doug Chapman <doug.chapman@hp.com>

Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/net/e1000/e1000_main.c