]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
kmemtrace, fs, security: move alloc_secdata() and free_secdata() to linux/security.h
authorPekka Enberg <penberg@cs.helsinki.fi>
Tue, 24 Mar 2009 09:59:23 +0000 (11:59 +0200)
committerIngo Molnar <mingo@elte.hu>
Fri, 3 Apr 2009 10:08:57 +0000 (12:08 +0200)
commit3d544f411f2971eb82f5c52322251eb04494542a
treeceeae2876e2ca76acf44e15bd64d98ffefb113d4
parent645dae969c3b8651c5bc7c54a1835ec03820f85f
kmemtrace, fs, security: move alloc_secdata() and free_secdata() to linux/security.h

Impact: cleanup

We want to remove percpu.h from rcupdate.h (for upcoming kmemtrace
changes), but this is not possible currently without breaking the
build because fs.h has implicit include file depedencies: it uses
GFP_* types in inlines but does not include gfp.h.

In practice most fs.h using .c files get gfp.h included implicitly,
via an indirect route: via rcupdate.h inclusion - so this underlying
problem gets masked in practice.

So we want to solve fs.h's dependency on gfp.h.

gfp.h can not be included here directly because it is not exported and it
would break the build the following way:

  /home/mingo/tip/usr/include/linux/bsg.h:11: found __[us]{8,16,32,64} type without #include <linux/types.h>
  /home/mingo/tip/usr/include/linux/fs.h:11: included file 'linux/gfp.h' is not exported
  make[3]: *** [/home/mingo/tip/usr/include/linux/.check] Error 1
  make[2]: *** [linux] Error 2

As suggested by Alexey Dobriyan, move alloc_secdata() and free_secdata()
to linux/security.h - they belong there. This also cleans fs.h of GFP_*
usage.

Suggested-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
LKML-Reference: <1237906803.25315.96.camel@penberg-laptop>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
include/linux/fs.h
include/linux/security.h