]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] libertas: skb dereferenced after netif_rx
authorFlorin Malita <fmalita@gmail.com>
Fri, 18 May 2007 20:04:33 +0000 (16:04 -0400)
committerJohn W. Linville <linville@tuxdriver.com>
Tue, 22 May 2007 15:02:29 +0000 (11:02 -0400)
commit3d4bd24b019981394fabb465b0c7932924b83d65
treec2103071362f7478577b5bf5fa4621fe79fd6ea8
parent55b637c6a003a8c4850b41a2c2fd6942d8a7f530
[PATCH] libertas: skb dereferenced after netif_rx

In libertas_process_rxed_packet() and process_rxed_802_11_packet() the
skb is dereferenced after being passed to netif_rx (called from
libertas_upload_rx_packet). Spotted by Coverity (1658, 1659).

Also, libertas_upload_rx_packet() unconditionally returns 0 so the error
check is dead code - might as well take it out and change the signature.

Signed-off-by: Florin Malita <fmalita@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/libertas/decl.h
drivers/net/wireless/libertas/rx.c