]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
netdevice zd1201: Convert directly reference of netdev->priv to netdev_priv()
authorJohn W. Linville <linville@tuxdriver.com>
Fri, 31 Oct 2008 18:13:12 +0000 (14:13 -0400)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 21 Nov 2008 16:06:02 +0000 (11:06 -0500)
commit3d29b0c33d431ecc69ec778f8c236d382f59a85f
treeb11d062b298f72d76234259bc54e925439b5c2cf
parent9d2f4720971c00852a3fc8278a76f1a5e9add5c7
netdevice zd1201: Convert directly reference of netdev->priv to netdev_priv()

We have some reasons to kill netdev->priv:
1. netdev->priv is equal to netdev_priv().
2. netdev_priv() wraps the calculation of netdev->priv's offset, obviously
   netdev_priv() is more flexible than netdev->priv.
But we cann't kill netdev->priv, because so many drivers reference to it
directly.

OK, becasue Dave S. Miller said, "every direct netdev->priv usage is a bug",
and I want to kill netdev->priv later, I decided to convert all the direct
reference of netdev->priv first.

(Original patch posted by Wang Chen <wangchen@cn.fujitsu.com> w/ above
changelog but using dev->ml_priv.  That doesn't seem appropriate
to me for this driver, so I've revamped it to use netdev_priv()
instead. -- JWL)

Reviewed-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/zd1201.c