]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
vsprintf: fix bug in negative value printing
authorFrederic Weisbecker <fweisbec@gmail.com>
Mon, 9 Mar 2009 20:15:04 +0000 (21:15 +0100)
committerIngo Molnar <mingo@elte.hu>
Tue, 10 Mar 2009 12:15:06 +0000 (13:15 +0100)
commit39e874f8afbdb3745e2406ce4ecbde9ac4cbaa78
tree7803af729748413da864811ebcc7a44cd98bbe52
parentfef20d9c1380f04ba9492d6463148db07b413708
vsprintf: fix bug in negative value printing

Sitsofe Wheeler found and bisected that while unifying the
vsprintf format decoding in:

  fef20d9: vsprintf: unify the format decoding layer for its 3 users

The sign flag has been dropped out in favour of
precise types (ie: LONG/ULONG).

But the format helper number() still needs this flag to keep track of
the signedness unless it will consider all numbers as unsigned.

Also add an explicit cast to int (for %d) while parsing with va_arg()
to ensure the highest bit is well extended on the 64 bits number that
hosts the value in case of negative values.

Reported-Bisected-Tested-by: Sitsofe Wheeler <sitsofe@yahoo.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
LKML-Reference: <20090309201503.GA5010@nowhere>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
lib/vsprintf.c