]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] knfsd: match GRANTED_RES replies using cookies
authorOlaf Kirch <okir@suse.de>
Wed, 4 Oct 2006 09:16:03 +0000 (02:16 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Wed, 4 Oct 2006 14:55:18 +0000 (07:55 -0700)
commit39be4502cb75dc26007fe1659735b26c8e63fcc6
tree0f4c6bf14f8a975178b3192bfc9ba942da56619f
parent031d869d0e0be18cfe35526be5608225b8f0a7be
[PATCH] knfsd: match GRANTED_RES replies using cookies

When we send a GRANTED_MSG call, we current copy the NLM cookie provided in
the original LOCK call - because in 1996, some broken clients seemed to rely
on this bug.  However, this means the cookies are not unique, so that when the
client's GRANTED_RES message comes back, we cannot simply match it based on
the cookie, but have to use the client's IP address in addition.  Which breaks
when you have a multi-homed NFS client.

The X/Open spec explicitly mentions that clients should not expect the same
cookie; so one may hope that any clients that were broken in 1996 have either
been fixed or rendered obsolete.

Signed-off-by: Olaf Kirch <okir@suse.de>
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/lockd/svc4proc.c
fs/lockd/svclock.c
fs/lockd/svcproc.c
include/linux/lockd/lockd.h