]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
bnx2x: loopback test failure
authorEilon Greenstein <eilong@broadcom.com>
Thu, 22 Jan 2009 06:01:32 +0000 (06:01 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 22 Jan 2009 21:47:12 +0000 (13:47 -0800)
commit3910c8ae44c59cebed721e33aa496f0a385b4e03
treef299416ca45f71484235a599d7ecff46e901fd4e
parent5650d9d4cbf3898d3f9725ccad5dfca6bc086324
bnx2x: loopback test failure

A link change interrupt might be queued and activated after the loopback was set
and it will cause the loopback to fail. The PHY lock should be kept until the
loopback test is over.

That implies that the bnx2x_test_link should used within the loopback function
and not bnx2x_wait_for_link since that function also takes the PHY link

Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bnx2x_main.c