]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] Fix oops in sysfs_hash_and_remove_file()
authorJames Bottomley <James.Bottomley@SteelEye.com>
Sat, 27 Aug 2005 01:34:17 +0000 (18:34 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Sat, 27 Aug 2005 02:37:13 +0000 (19:37 -0700)
commit36676bcbf9f6bcbea9d06e67ee8d04eacde54952
treef31e9a79a643cfba649637164a559d94b4183ccc
parent657390d25d4241705cb4fc5b3b4ba5b30575dc17
[PATCH] Fix oops in sysfs_hash_and_remove_file()

The problem arises if an entity in sysfs is created and removed without
ever having been made completely visible.  In SCSI this is triggered by
removing a device while it's initialising.

The problem appears to be that because it was never made visible in sysfs,
the sysfs dentry has a null d_inode which oopses when a reference is made
to it.  The solution is simply to check d_inode and assume the object was
never made visible (and thus doesn't need deleting) if it's NULL.

(akpm: possibly a stopgap for 2.6.13 scsi problems.  May not be the
long-term fix)

Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/sysfs/inode.c