]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] amiga: fix driver_register() return handling, remove zorro_module_init()
authorBjorn Helgaas <bjorn.helgaas@hp.com>
Sat, 25 Mar 2006 11:07:20 +0000 (03:07 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Sat, 25 Mar 2006 16:22:53 +0000 (08:22 -0800)
commit33d8675ea66e79d21da3ed64ce88dfb2a18bc6a7
tree7283a680e122e4d15f50e818bab188b84fc852a9
parentc2f6fabb2ed3b869bc254c6cdc73d6beaaaf700f
[PATCH] amiga: fix driver_register() return handling, remove zorro_module_init()

Remove the assumption that driver_register() returns the number of devices
bound to the driver.  In fact, it returns zero for success or a negative
error value.

zorro_module_init() used the device count to automatically unregister and
unload drivers that found no devices.  That might have worked at one time,
but has been broken for some time because zorro_register_driver() returned
either a negative error or a positive count (never zero).  So it could only
unregister on failure, when it's not needed anyway.

This functionality could be resurrected in individual drivers by counting
devices in their .probe() methods.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Roman Zippel <zippel@linux-m68k.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/net/a2065.c
drivers/net/ariadne.c
drivers/net/hydra.c
drivers/net/zorro8390.c
drivers/video/cirrusfb.c
drivers/zorro/zorro-driver.c
include/linux/zorro.h