]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
dcache: don't expose uninitialized memory in /proc/<pid>/fd/<fd>
authorJ. Bruce Fields <bfields@citi.umich.edu>
Sun, 21 Oct 2007 23:41:38 +0000 (16:41 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Mon, 22 Oct 2007 15:13:18 +0000 (08:13 -0700)
commit321bcf92163038e2b96fd3bf9bc29f755c81d9ef
tree68a1e6b659cac5ffdadb4b7412fa5b7a4244541b
parentb68680e4731abbd78863063aaa0dca2a6d8cc723
dcache: don't expose uninitialized memory in /proc/<pid>/fd/<fd>

Well, it's not especially important that target->d_iname get the contents
of dentry->d_iname, but it's important that it get initialized with
*something*, otherwise we're just exposing some random piece of memory to
anyone who reads the link at /proc/<pid>/fd/<fd> for the deleted file, when
it's still held open by someone.

I've run a test program that copies a short (<36 character) name ontop of a
long (>=36 character) name and see that the first time I run it, without
this patch, I get unpredicatable results out of /proc/<pid>/fd/<fd>.

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/dcache.c