]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
bonding: Fix use after free in unregister path
authorJay Vosburgh <fubar@us.ibm.com>
Tue, 19 Jun 2007 18:12:12 +0000 (11:12 -0700)
committerJeff Garzik <jeff@garzik.org>
Wed, 20 Jun 2007 23:12:41 +0000 (19:12 -0400)
commit3201e656ce56ed02e9501906c18ffe16ae350a52
tree8dbe0df57ffb7afd7fe1aac65fcd0ae0600870f0
parent3a2c892daaf54b31a70785c2821771e8094188ed
bonding: Fix use after free in unregister path

The following patch (based on a patch from Stephen Hemminger
<shemminger@linux-foundation.org>) removes use after free conditions in
the unregister path for the bonding master.  Without this patch, an
operation of the form "echo -bond0 > /sys/class/net/bonding_masters"
would trigger a NULL pointer dereference in sysfs.  I was not able to
induce the failure with the non-sysfs code path, but for consistency I
updated that code as well.

I also did some testing of the bonding /proc file being open
while the bond is being deleted, and didn't see any problems there.

Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/net/bonding/bond_main.c
drivers/net/bonding/bond_sysfs.c