]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
cpumask: fix CONFIG_CPUMASK_OFFSTACK=y cpu hotunplug crash
authorRusty Russell <rusty@rustcorp.com.au>
Tue, 17 Mar 2009 04:20:34 +0000 (14:50 +1030)
committerIngo Molnar <mingo@elte.hu>
Wed, 18 Mar 2009 08:40:35 +0000 (09:40 +0100)
commit30e1e6d1af2b67558bccf322af2b3e0676b209ae
treedae658631d0bb038c373cc2ba34ecf43f31ebd25
parent082edb7bf443eb8eda15b482d16ad9dd8137ad24
cpumask: fix CONFIG_CPUMASK_OFFSTACK=y cpu hotunplug crash

Impact: Fix cpu offline when CONFIG_MAXSMP=y

Changeset bc9b83dd1f66402b870301c3c7117b9c1484abb4 "cpumask: convert
c1e_mask in arch/x86/kernel/process.c to cpumask_var_t" contained a
bug: c1e_mask is manipulated even if C1E isn't detected (and hence
not allocated).

This is simply fixed by checking for NULL (which gcc optimizes out
anyway of CONFIG_CPUMASK_OFFSTACK=n, since it knows ce1_mask can never
be NULL).

In addition, fix a leak where select_idle_routine re-allocates
(and re-clears) c1e_mask on every cpu init.

Reported-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Cc: Mike Travis <travis@sgi.com>
LKML-Reference: <200903171450.34549.rusty@rustcorp.com.au>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/include/asm/processor.h
arch/x86/kernel/cpu/common.c
arch/x86/kernel/process.c