]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
gro: Fix legacy path napi_complete crash
authorHerbert Xu <herbert@gondor.apana.org.au>
Tue, 17 Mar 2009 20:11:29 +0000 (13:11 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 17 Mar 2009 20:11:29 +0000 (13:11 -0700)
commit303c6a0251852ecbdc5c15e466dcaff5971f7517
treec75ff5ae3238d54e1dea0813bf3177a11faf0dd0
parentea8dbdd17099a9a5864ebd4c87e01e657b19c7ab
gro: Fix legacy path napi_complete crash

On the legacy netif_rx path, I incorrectly tried to optimise
the napi_complete call by using __napi_complete before we reenable
IRQs.  This simply doesn't work since we need to flush the held
GRO packets first.

This patch fixes it by doing the obvious thing of reenabling
IRQs first and then calling napi_complete.

Reported-by: Frank Blaschka <blaschka@linux.vnet.ibm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/dev.c