]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
advansys fix on ISA-less configs
authorAl Viro <viro@ftp.linux.org.uk>
Sat, 22 Nov 2008 17:34:54 +0000 (17:34 +0000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sun, 30 Nov 2008 18:03:36 +0000 (10:03 -0800)
commit30037818f7c1e11cb3742fbecd614ef3dc7b27bb
treede09371c449e130eac12bc195efedea420488683
parent2fceab0bd8d82509519e9b842a5a7234b2397fb4
advansys fix on ISA-less configs

The code

        if (shost->dma_channel != NO_ISA_DMA)
                free_dma(shost->dma_channel);

in there is triggerable only if we have CONFIG_ISA (we only set ->dma_channel to
something other than NO_ISA_DMA under #ifdef CONFIG_ISA).  OTOH, free_dma() is
not guaranteed to be there in absense of CONFIG_ISA.  IOW, driver runs into
undefined symbols on PCI-but-not-ISA configs (e.g. on frv) and it's a false
positive.

Fix: put the entire if () under #ifdef CONFIG_ISA; behaviour doesn't change and
dependency on free_dma() disappears for !CONFIG_ISA.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/scsi/advansys.c