]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] x86_64/i386 irq: Fix !CONFIG_SMP compilation
authorEric W. Biederman <ebiederm@xmission.com>
Tue, 27 Feb 2007 07:27:41 +0000 (00:27 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Wed, 28 Feb 2007 16:52:31 +0000 (08:52 -0800)
commit2ff7354fe888f46f6629b57e463b0a1eb956c02b
tree2bb8b404065fb27141ca1d4fe8a6bc35fe2162bd
parent606135a3081e045b677cde164a296c51f66c4633
[PATCH] x86_64/i386 irq: Fix !CONFIG_SMP compilation

When removing set_native_irq I missed the fact that it was
called in a couple of places that were compiled even when
SMP support is disabled.  And since the irq_desc[].affinity
field only exists in SMP things broke.

Thanks to Simon Arlott <simon@arlott.org> for spotting this.

There are a couple of ways to fix this but the simplest one
is to just remove the assignments.  The affinity field is only
used to display a value to the user, and nothing on either i386
or x86_64 reads it or depends on it being any particlua value,
so skipping the assignment is safe.  The assignment that
is being removed is just for the initial affinity value before
the user explicitly sets it.  The irq_desc array initializes
this field to CPU_MASK_ALL so the field is initialized to
a reasonable value in the SMP case without being set.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/i386/kernel/io_apic.c
arch/x86_64/kernel/io_apic.c