]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[NET]: Marking struct pernet_operations __net_initdata was inappropriate
authorEric W. Biederman <ebiederm@xmission.com>
Sat, 27 Oct 2007 05:54:53 +0000 (22:54 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 27 Oct 2007 05:54:53 +0000 (22:54 -0700)
commit2b008b0a8e96b726c603c5e1a5a7a509b5f61e35
tree80d71a763d3e8365805203cf22093783e64e1bbc
parent72998d8c84247817c4b8b05b0256f29453e435f5
[NET]: Marking struct pernet_operations __net_initdata was inappropriate

It is not safe to to place struct pernet_operations in a special section.
We need struct pernet_operations to last until we call unregister_pernet_subsys.
Which doesn't happen until module unload.

So marking struct pernet_operations is a disaster for modules in two ways.
- We discard it before we call the exit method it points to.
- Because I keep struct pernet_operations on a linked list discarding
  it for compiled in code removes elements in the middle of a linked
  list and does horrible things for linked insert.

So this looks safe assuming __exit_refok is not discarded
for modules.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/loopback.c
fs/proc/proc_net.c
include/net/net_namespace.h
net/core/dev.c
net/core/dev_mcast.c
net/netlink/af_netlink.c