]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] Fix and add EXPORT_SYMBOL(filemap_write_and_wait)
authorOGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Sun, 8 Jan 2006 09:02:14 +0000 (01:02 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Mon, 9 Jan 2006 04:13:47 +0000 (20:13 -0800)
commit28fd129827b00e12829d48a5290f46277600619b
tree38e50e1b88965fec41ea5b36aa557fb5c2b1ca73
parent05eb0b51fb46430050d5873458612f53e0234f2e
[PATCH] Fix and add EXPORT_SYMBOL(filemap_write_and_wait)

This patch add EXPORT_SYMBOL(filemap_write_and_wait) and use it.

See mm/filemap.c:

And changes the filemap_write_and_wait() and filemap_write_and_wait_range().

Current filemap_write_and_wait() doesn't wait if filemap_fdatawrite()
returns error.  However, even if filemap_fdatawrite() returned an
error, it may have submitted the partially data pages to the device.
(e.g. in the case of -ENOSPC)

<quotation>
Andrew Morton writes,

If filemap_fdatawrite() returns an error, this might be due to some
I/O problem: dead disk, unplugged cable, etc.  Given the generally
crappy quality of the kernel's handling of such exceptions, there's a
good chance that the filemap_fdatawait() will get stuck in D state
forever.
</quotation>

So, this patch doesn't wait if filemap_fdatawrite() returns the -EIO.

Trond, could you please review the nfs part?  Especially I'm not sure,
nfs must use the "filemap_fdatawrite(inode->i_mapping) == 0", or not.

Acked-by: Trond Myklebust <trond.myklebust@fys.uio.no>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
16 files changed:
fs/9p/vfs_dir.c
fs/9p/vfs_file.c
fs/buffer.c
fs/cifs/file.c
fs/cifs/inode.c
fs/jfs/jfs_dmap.c
fs/jfs/jfs_imap.c
fs/jfs/jfs_txnmgr.c
fs/jfs/jfs_umount.c
fs/jfs/resize.c
fs/jfs/super.c
fs/nfs/inode.c
fs/smbfs/file.c
fs/smbfs/inode.c
fs/xfs/linux-2.6/xfs_fs_subr.c
mm/filemap.c