]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
backlight: Fix external uses of backlight internal semaphore
authorRichard Purdie <rpurdie@rpsys.net>
Thu, 8 Feb 2007 22:25:09 +0000 (22:25 +0000)
committerRichard Purdie <rpurdie@rpsys.net>
Tue, 20 Feb 2007 08:38:45 +0000 (08:38 +0000)
commit28ee086d5b36aab2931f6740e409bb0fb6c65e5f
tree0a308c80affcc39c2c869f29f1109e5ee9d6140f
parenta8db3c1948eb30cd6988b5b96b654f591e6280b1
backlight: Fix external uses of backlight internal semaphore

backlight_device->sem has a very specific use as documented in the
header file. The external users of this are using it for a different
reason, to serialise access to the update_status() method.

backlight users were supposed to implement their own internal
serialisation of update_status() if needed but everyone is doing
things differently and incorrectly. Therefore add a global mutex to
take care of serialisation for everyone, once and for all.

Locking for get_brightness remains optional since most users don't
need it.

Also update the lcd class in a similar way.

Signed-off-by: Richard Purdie <rpurdie@rpsys.net>
15 files changed:
arch/powerpc/kernel/traps.c
arch/powerpc/platforms/powermac/backlight.c
drivers/macintosh/via-pmu-backlight.c
drivers/misc/asus-laptop.c
drivers/usb/misc/appledisplay.c
drivers/video/aty/aty128fb.c
drivers/video/aty/atyfb_base.c
drivers/video/aty/radeon_backlight.c
drivers/video/backlight/backlight.c
drivers/video/backlight/lcd.c
drivers/video/chipsfb.c
drivers/video/nvidia/nv_backlight.c
drivers/video/riva/fbdev.c
include/linux/backlight.h
include/linux/lcd.h