]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
thinkpad-acpi: remove HKEY disable functionality
authorHenrique de Moraes Holschuh <hmh@hmh.eng.br>
Sat, 4 Apr 2009 04:25:48 +0000 (04:25 +0000)
committerLen Brown <len.brown@intel.com>
Sat, 4 Apr 2009 07:14:52 +0000 (03:14 -0400)
commit2586d5663d0a17d69383acf6110f16a979a07c4e
tree5bfe1ef88ee03084175bb94c4c1079402fefbe7b
parent73a94d86a8625371f76de0ee12dc5bacd3ed42c0
thinkpad-acpi: remove HKEY disable functionality

The HKEY disable functionality basically cripples the entire event
model of the ThinkPad firmware and of the thinkpad-acpi driver.
Remove this functionality from the driver.  HKEY must be enabled at
all times while thinkpad-acpi is loaded, and disabled otherwise.

For sysfs, according to the sysfs ABI and the thinkpad-acpi sysfs
rules of engagement, we will just remove the attributes.  This will be
done in two stages: disable their function now, after two kernel
releases, remove the attributes.

For procfs, we call WARN().  If nothing triggers it, I will simply
remove the enable/disable commands entirely in the future along with
the sysfs attributes.

I don't expect much, if any fallout from this.  There really isn't any
reason to mess with hotkey_enable or with the enable/disable commands
to /proc/acpi/ibm/hotkey, and this has been true for years...

Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Signed-off-by: Len Brown <len.brown@intel.com>
Documentation/laptops/thinkpad-acpi.txt
drivers/platform/x86/thinkpad_acpi.c