]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
virtio: remove overzealous BUG_ON.
authorRusty Russell <rusty@rustcorp.com.au>
Mon, 7 Apr 2008 04:30:28 +0000 (14:30 +1000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 7 Apr 2008 20:14:22 +0000 (13:14 -0700)
commit2557a933b795c1988c721ebb871cd735128bb9cb
tree96581bd5acac44bbe0399aa445197509d9ae60ff
parent4cac04dd63fa3b202ee313ed1afbbd135ab887ee
virtio: remove overzealous BUG_ON.

The 'disable_cb' callback is designed as an optimization to tell the host
we don't need callbacks now.  As it is not reliable, the debug check is
overzealous: it can happen on two CPUs at the same time.  Document this.

Even if it were reliable, the virtio_net driver doesn't disable
callbacks on transmit so the START_USE/END_USE debugging reentrance
protection can be easily tripped even on UP.

Thanks to Balaji Rao for the bug report and testing.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
CC: Balaji Rao <balajirrao@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/virtio/virtio_ring.c
include/linux/virtio.h