]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[NETPOLL]: Fixups for 'fix soft lockup when removing module'
authorJarek Poplawski <jarkao2@o2.pl>
Fri, 6 Jul 2007 00:42:44 +0000 (17:42 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 6 Jul 2007 00:42:44 +0000 (17:42 -0700)
commit25442cafb8cc3d979418caccabc91260707a0947
tree3f934e686d37619a211946f5d78dd28fad82e61b
parent94b83419e5b56a87410fd9c9939f0081fc155d65
[NETPOLL]: Fixups for 'fix soft lockup when removing module'

>From my recent patch:

> >    #1
> >    Until kernel ver. 2.6.21 (including) cancel_rearming_delayed_work()
> >    required a work function should always (unconditionally) rearm with
> >    delay > 0 - otherwise it would endlessly loop. This patch replaces
> >    this function with cancel_delayed_work(). Later kernel versions don't
> >    require this, so here it's only for uniformity.

But Oleg Nesterov <oleg@tv-sign.ru> found:

> But 2.6.22 doesn't need this change, why it was merged?
>
> In fact, I suspect this change adds a race,
...

His description was right (thanks), so this patch reverts #1.

Signed-off-by: Jarek Poplawski <jarkao2@o2.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/netpoll.c