]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
Fix a race condition in FASYNC handling
authorJonathan Corbet <corbet@lwn.net>
Fri, 5 Dec 2008 23:12:48 +0000 (16:12 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 5 Dec 2008 23:35:10 +0000 (15:35 -0800)
commit218d11a8b071b23b76c484fd5f72a4fe3306801e
tree6656f841973496b0717117f8031d22bea019fd00
parentf2f1fa78a155524b849edf359e42a3001ea652c0
Fix a race condition in FASYNC handling

Changeset a238b790d5f99c7832f9b73ac8847025815b85f7 (Call fasync()
functions without the BKL) introduced a race which could leave
file->f_flags in a state inconsistent with what the underlying
driver/filesystem believes.  Revert that change, and also fix the same
races in ioctl_fioasync() and ioctl_fionbio().

This is a minimal, short-term fix; the real fix will not involve the
BKL.

Reported-by: Oleg Nesterov <oleg@redhat.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: stable@kernel.org
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/fcntl.c
fs/ioctl.c