]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[SCSI] fix intermittent oops in scsi_bus_uevent
authorJames Bottomley <James.Bottomley@HansenPartnership.com>
Thu, 22 May 2008 11:34:41 +0000 (12:34 +0100)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Fri, 23 May 2008 21:17:06 +0000 (16:17 -0500)
commit1f42ea7bc0ddfadebd9e1c5362b41b53902dbcb1
tree3b2ee1a6b64522cd073f14773086cec0b8d824a0
parent7853099a70742b2a3c753282e5ccfbdda86cb29f
[SCSI] fix intermittent oops in scsi_bus_uevent

Reported-by: Sitsofe Wheeler <sitsofe@yahoo.com>
> BUG: unable to handle kernel paging request at e6f17fac
> IP: [<c02604d6>] scsi_bus_uevent+0x1/0x17
> *pde = 2714b163 *pte = 26f17160
> Oops: 0000 [#1] DEBUG_PAGEALLOC
> last sysfs file:
>
> Pid:  1, comm: swapper Not tainted (2.6.26-rc2-next-20080516skw #30)
> EIP: 0060:[<c02604d6>] EFLAGS: 00010282 CPU: 0
> EIP is at scsi_bus_uevent+0x1/0x17
> EAX: e6f18014 EBX: e6f18014 ECX: c02604d5 EDX: e7173000
> ESI: e7173000 EDI: e7173000 EBP: e7851ca0 ESP: e7851c90
>  DS: 007b ES: 007b FS: 0000 GS: 0000 SS: 0068

The problem is caused by:

commit b0ed43360fdca227048d88a08290365cb681c1a8
Author: Hannes Reinecke <hare@suse.de>
Date:   Tue Mar 18 14:32:28 2008 +0100

    [SCSI] add scsi_host and scsi_target to scsi_bus

which added scsi_bus_type to the struct scsi_target device.  This
causes both the scsi_device and scsi_target to fire scsi_bus_uevents.
However, the actualy scsi_bus_uevent() call assumes blindly that it's
a struct scsi_device.  Check for this and return immediately if it
isn't.

Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/scsi/scsi_sysfs.c