]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
firewire: cdev: tcodes input validation
authorStefan Richter <stefanr@s5r6.in-berlin.de>
Fri, 5 Dec 2008 21:44:42 +0000 (22:44 +0100)
committerStefan Richter <stefanr@s5r6.in-berlin.de>
Tue, 24 Mar 2009 19:56:37 +0000 (20:56 +0100)
commit1f3125af8ed7410cc0ebcc0acd59bbfc1ae0057a
tree3e0cd754d86b8780b164bd507564fd2355c7db29
parentbf8e3355ec8f4e472f9841e94203cd759b45226e
firewire: cdev: tcodes input validation

The behaviour of fw-transaction.c::fw_send_request is ill-defined for
any other tcodes than read/ write/ lock request tcodes.  Therefore
prevent requests with wrong tcodes from entering the transaction layer.

Maybe fw_send_request should check them itself, but I am not inclined to
change it and fw_fill_request from void-valued functions to ones which
return error codes and pass those up.  Besides, maybe fw_send_request is
going to support one more tcode than ioctl_send_request in the future
(TCODE_STREAM_DATA).

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
drivers/firewire/fw-cdev.c