]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] uml: fixes performance regression in activate_mm and thus exec()
authorPaolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Sat, 3 Sep 2005 22:57:25 +0000 (15:57 -0700)
committerLinus Torvalds <torvalds@evo.osdl.org>
Mon, 5 Sep 2005 07:06:21 +0000 (00:06 -0700)
commit1e40cd383ccc7c9f8b338c56ce28c326e25eb2fe
tree8dab0fb849ccc25febf6c8f8865094141a50b8d2
parented1b58d8b53519e10a35c6a2bb49cac35f439621
[PATCH] uml: fixes performance regression in activate_mm and thus exec()

Normally, activate_mm() is called from exec(), and thus it used to be a
no-op because we use a completely new "MM context" on the host (for
instance, a new process), and so we didn't need to flush any "TLB entries"
(which for us are the set of memory mappings for the host process from the
virtual "RAM" file).

Kernel threads, instead, are usually handled in a different way.  So, when
for AIO we call use_mm(), things used to break and so Benjamin implemented
activate_mm().  However, that is only needed for AIO, and could slow down
exec() inside UML, so be smart: detect being called for AIO (via
PF_BORROWED_MM) and do the full flush only in that situation.

Comment also the caller so that people won't go breaking UML without
noticing.  I also rely on the caller's locks for testing current->flags.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
CC: Benjamin LaHaise <bcrl@kvack.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/aio.c
include/asm-um/mmu_context.h