]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
dccp: Fix sparse warnings
authorGerrit Renker <gerrit@erg.abdn.ac.uk>
Wed, 11 Jun 2008 10:19:09 +0000 (11:19 +0100)
committerGerrit Renker <gerrit@erg.abdn.ac.uk>
Wed, 11 Jun 2008 10:19:09 +0000 (11:19 +0100)
commit1e2f0e5e8376f2a0ada8760fc9d3104e1a81382b
tree8e0dc375e574092814d7d020292cf6df67db5bb1
parent3294f202dc1acd82223e83ef59f272bd87bb06b2
dccp: Fix sparse warnings

This patch fixes the following sparse warnings:
 * nested min(max()) expression:
   net/dccp/ccids/ccid3.c:91:21: warning: symbol '__x' shadows an earlier one
   net/dccp/ccids/ccid3.c:91:21: warning: symbol '__y' shadows an earlier one

 * Declaration of function prototypes in .c instead of .h file, resulting in
   "should it be static?" warnings.

 * Declared "struct dccpw" static (local to dccp_probe).

 * Disabled dccp_delayed_ack() - not fully removed due to RFC 4340, 11.3
   ("Receivers SHOULD implement delayed acknowledgement timers ...").

 * Used a different local variable name to avoid
   net/dccp/ackvec.c:293:13: warning: symbol 'state' shadows an earlier one
   net/dccp/ackvec.c:238:33: originally declared here

 * Removed unused functions `dccp_ackvector_print' and `dccp_ackvec_print'.

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
net/dccp/ackvec.c
net/dccp/ccids/ccid3.c
net/dccp/ccids/lib/tfrc.c
net/dccp/ccids/lib/tfrc.h
net/dccp/output.c
net/dccp/probe.c