]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
mm: task dirty accounting fix
authorNick Piggin <npiggin@suse.de>
Wed, 18 Feb 2009 22:48:18 +0000 (14:48 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 18 Feb 2009 23:37:54 +0000 (15:37 -0800)
commit1cf6e7d83bf334cc5916137862c920a97aabc018
tree6bdbc4a98e9b332919beaeba0649797fff544795
parent610d18f4128ebbd88845d0fc60cce67b49af881e
mm: task dirty accounting fix

YAMAMOTO-san noticed that task_dirty_inc doesn't seem to be called properly for
cases where set_page_dirty is not used to dirty a page (eg. mark_buffer_dirty).

Additionally, there is some inconsistency about when task_dirty_inc is
called.  It is used for dirty balancing, however it even gets called for
__set_page_dirty_no_writeback.

So rather than increment it in a set_page_dirty wrapper, move it down to
exactly where the dirty page accounting stats are incremented.

Cc: YAMAMOTO Takashi <yamamoto@valinux.co.jp>
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/buffer.c
include/linux/mm.h
mm/page-writeback.c