]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
pm: rework disabling of user mode helpers during suspend/hibernation
authorRafael J. Wysocki <rjw@sisk.pl>
Thu, 16 Oct 2008 05:01:21 +0000 (22:01 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 16 Oct 2008 18:21:29 +0000 (11:21 -0700)
commit1bfcf1304ea79c46efc3724e548b13b4b442b418
tree5adbf95b25d1d9e86fc0e5d0784550ccb9bf5be9
parent574f34cee2b6574d43bf4506f771c1cec6a5d391
pm: rework disabling of user mode helpers during suspend/hibernation

We currently use a PM notifier to disable user mode helpers before suspend
and hibernation and to re-enable them during resume.  However, this is not
an ideal solution, because if any drivers want to upload firmware into
memory before suspend, they have to use a PM notifier for this purpose and
there is no guarantee that the ordering of PM notifiers will be as
expected (ie.  the notifier that disables user mode helpers has to be run
after the driver's notifier used for uploading the firmware).

For this reason, it seems better to move the disabling and enabling of
user mode helpers to separate functions that will be called by the PM core
as necessary.

[akpm@linux-foundation.org: remove unneeded ifdefs]
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Cc: Alan Stern <stern@rowland.harvard.edu>
Acked-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
include/linux/kmod.h
kernel/kmod.c
kernel/power/disk.c
kernel/power/main.c
kernel/power/user.c