]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
rationalise return value for ->hot_add_disk method.
authorNeil Brown <neilb@notabene.brown>
Fri, 27 Jun 2008 22:31:33 +0000 (08:31 +1000)
committerNeil Brown <neilb@notabene.brown>
Fri, 27 Jun 2008 22:31:33 +0000 (08:31 +1000)
commit199050ea1ff2270174ee525b73bc4c3323098897
treeb2a7851511b2ddb943b9ff7ce7c8a96c3ac2a8bb
parent6c2fce2ef6b4821c21b5c42c7207cb9cf8c87eda
rationalise return value for ->hot_add_disk method.

For all array types but linear, ->hot_add_disk returns 1 on
success, 0 on failure.
For linear, it returns 0 on success and -errno on failure.

This doesn't cause a functional problem because the ->hot_add_disk
function of linear is used quite differently to the others.
However it is confusing.

So convert all to return 0 for success or -errno on failure
and fix call sites to match.

Signed-off-by: Neil Brown <neilb@suse.de>
drivers/md/md.c
drivers/md/multipath.c
drivers/md/raid1.c
drivers/md/raid10.c
drivers/md/raid5.c