]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
tracing: stop command line recording when tracing is disabled
authorThomas Gleixner <tglx@linutronix.de>
Wed, 18 Mar 2009 07:56:58 +0000 (08:56 +0100)
committerIngo Molnar <mingo@elte.hu>
Wed, 18 Mar 2009 09:10:16 +0000 (10:10 +0100)
commit18aecd362a1c991fbf5f7919ae051a77532ba2f8
treef19f11afa2b669a6acea5c98fda091b68993bc59
parent03418c7efaa429dc7647ac93e3862e3fe1816873
tracing: stop command line recording when tracing is disabled

Impact: prevent overwrite of command line entries

When the tracer is stopped the command line recording continues to
record. The check for tracing_is_on() is not sufficient here as the
ringbuffer status is not affected by setting
debug/tracing/tracing_enabled to 0. On a non idle system this can
result in the loss of the command line information for the stopped
trace, which makes the trace harder to read and analyse.

Check tracer_enabled to allow further recording.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Steven Rostedt <srostedt@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/trace/trace.c