]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
kconfig: fix randconfig for choice blocks
authorSam Ravnborg <sam@ravnborg.org>
Sun, 15 Mar 2009 10:05:12 +0000 (11:05 +0100)
committerSam Ravnborg <sam@ravnborg.org>
Sun, 15 Mar 2009 21:54:57 +0000 (22:54 +0100)
commit184832c981fd38b1052f2dfa0262e793fa6c67d3
treebe1f3abb2f83fb20997ffcf770441610114bbf3f
parent5bee17f18b595937e6beafeee5197868a3f74a06
kconfig: fix randconfig for choice blocks

Ingo Molnar reported that 'make randconfig' was not covering
choice blocks properly, resulting in certain config options
being left out of randconfig testing altogether.

With the following patch we:
- properly randomize choice value for normal choice blocks
- properly randomize for multi choice blocks
- added several comments to explain what is going on

The root cause of the bug was that SYMBOL_VALID was set on the
symbol representing the choice block so clearing this did
the trick initially.
But testign revealed a few more issues that is now fixed.

Reported-by: Ingo Molnar <mingo@elte.hu>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Roman Zippel <zippel@linux-m68k.org>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
scripts/kconfig/confdata.c