]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] i386: Clean up arch/i386/kernel/cpu/mcheck/p4.c
authorZachary Amsden <zach@vmware.com>
Wed, 2 May 2007 17:27:16 +0000 (19:27 +0200)
committerAndi Kleen <andi@basil.nowhere.org>
Wed, 2 May 2007 17:27:16 +0000 (19:27 +0200)
commit18420001d6ceafbe094a6f911126c6eee34d25c4
treee7f7061b9ee4ebde22e93df09300e0e20efac06e
parent959b4fdfe7e27bcf101e2381e500e4076f2bb9ce
[PATCH] i386: Clean up arch/i386/kernel/cpu/mcheck/p4.c

No, just no.  You do not use goto to skip a code block.  You do not
return an obvious variable from a singly-inlined function and give
the function a return value.  You don't put unexplained comments
about kmalloc in code which doesn't do dynamic allocation.  And
you don't leave stray warnings around for no good reason.

Also, when possible, it is better to use block scoped variables
because gcc can sometime generate better code.

Signed-off-by: Zachary Amsden <zach@vmware.com>
Signed-off-by: Andi Kleen <ak@suse.de>
arch/i386/kernel/cpu/mcheck/p4.c