]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
smsc9420: fix interrupt signalling test failures
authorSteve Glendinning <steve.glendinning@smsc.com>
Fri, 30 Jan 2009 01:29:15 +0000 (17:29 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 30 Jan 2009 01:29:15 +0000 (17:29 -0800)
commit1609559547ae0ddc2e4829c7f78ac2c4869875b9
tree8f06404437dc425a8c611ea6d9be064892470c97
parentb1c4a9dddf09fe99b8f88252718ac5b357363dc4
smsc9420: fix interrupt signalling test failures

smsc9420 performs an interrupt signalling test when the interface is
brought up.  The current code mistakenly sets its test flag to false
AFTER enabling the software interrupt source, making failure quite
likely.

This patch changes the code to set the test flag BEFORE enabling
interrupts. I've also removed an smp_wmb because the following spinlock
provides an implicit memory barrier.

Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/smsc9420.c