]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
nommu: ramfs: don't leak pages when adding to page cache fails
authorJohannes Weiner <hannes@cmpxchg.org>
Fri, 13 Mar 2009 20:51:58 +0000 (13:51 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 14 Mar 2009 18:57:22 +0000 (11:57 -0700)
commit15e7b8767605dc0cb9bd4594caabfec392385210
tree3826c146f7ecce8188d76d83c5bf2875e5890909
parent020fe22ff14320927f394de222cbb11708bcc7a8
nommu: ramfs: don't leak pages when adding to page cache fails

When a ramfs nommu mapping is expanded, contiguous pages are allocated
and added to the pagecache.  The caller's reference is then passed on
by moving whole pagevecs to the file lru list.

If the page cache adding fails, make sure that the error path also
moves the pagevec contents which might still contain up to PAGEVEC_SIZE
successfully added pages, of which we would leak references otherwise.

Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: David Howells <dhowells@redhat.com>
Cc: Enrik Berkhan <Enrik.Berkhan@ge.com>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/ramfs/file-nommu.c