]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[WATCHDOG] Fix declaration of struct smbios_entry_point in hpwdt
authorRoland Dreier <rdreier@cisco.com>
Thu, 28 Feb 2008 17:38:44 +0000 (09:38 -0800)
committerWim Van Sebroeck <wim@iguana.be>
Thu, 6 Mar 2008 11:10:35 +0000 (11:10 +0000)
commit103018aca2e4ba0d0e230efa864231c59228f419
treebc31aec77db886f23f26fca97ef341cc15d19a72
parent5e69960865ab6033a129f9ee35264adb2a1cfc94
[WATCHDOG] Fix declaration of struct smbios_entry_point in hpwdt

On my HP DL380 G5 system running a 64-bit kernel, loading the hpwdt
driver causes a crash because the driver attempts to ioremap an
invalid physical address.  This is because the driver has an incorrect
definition of the SMBIOS table entry point structure: the table
address is only a 32-bit quantity, and making it a u64 means that the
high-order 32 bits end up containing garbage.

Correcting the structure definition fixes the driver so that it loads
without any problems on my system.

Signed-off-by: Roland Dreier <rolandd@cisco.com>
Acked-by: Thomas Mingarelli <Thomas.Mingarelli@hp.com>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/watchdog/hpwdt.c