]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
libata: Fix early use of port printk. (Was Re: ata4294967295: failed to start port...
authorAlan Cox <alan@lxorguk.ukuu.org.uk>
Fri, 30 Nov 2007 15:23:16 +0000 (15:23 +0000)
committerJeff Garzik <jeff@garzik.org>
Sat, 1 Dec 2007 22:44:10 +0000 (17:44 -0500)
commit0f9fe9b7148f95f018ae2c97f7fa1a35364ea785
tree7690a22b6de42051502099e9f03b4c225abe1a94
parent04d86d6fc0477f217d60667adfc26f1f56264cc9
libata: Fix early use of port printk. (Was Re: ata4294967295: failed to start port (errno=-19))

On Fri, 30 Nov 2007 14:34:11 +0200 (EET)
Meelis Roos <mroos@linux.ee> wrote:

> > Can you stick a stack trace in at that point ? That would help diagnose
> > it a great deal quicker.
>
> Finally done - found out hard way that BUG() is too bad and
> dump_st5ack() suits me better.

Thanks. This should fix the real cause, and also allow for port start to
fail politely with -ENODEV.

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/ata/libata-core.c