]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[SCSI] sd: Refactor sd_read_capacity()
authorMatthew Wilcox <matthew@wil.cx>
Thu, 12 Mar 2009 18:20:29 +0000 (14:20 -0400)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Sat, 14 Mar 2009 13:42:56 +0000 (08:42 -0500)
commit0da205e01bc58cfad660659e3c901223d3596c57
tree3f199f3badd8148dd035f058580eb8870b1a0fec
parent635374e7eb110e80d9918b8611198edd56a32975
[SCSI] sd: Refactor sd_read_capacity()

The sd_read_capacity() function was about 180 lines long and
included a backwards goto and a tricky state variable.  Splitting out
read_capacity_10() and read_capacity_16() (about 50 lines each) reduces
sd_read_capacity to about 100 lines and gets rid of the backwards goto
and the state variable.  I've tried to avoid any behaviour change with
this patch.

[jejb: upped transfer request to standard recommended 32 for RC16]
Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/scsi/sd.c