]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
netfilter: ctnetlink: fix missing CTA_NAT_SEQ_UNSPEC
authorPablo Neira Ayuso <pablo@netfilter.org>
Tue, 16 Dec 2008 09:19:41 +0000 (01:19 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 16 Dec 2008 09:19:41 +0000 (01:19 -0800)
commit092cab7e2cd868cb0b30209a0337689c3ffd6133
treec99aff79e7c683a75ef9ba6ce91ecca51f8c6273
parenta3dd15444baa9c7522c8457ab564c41219dfb44c
netfilter: ctnetlink: fix missing CTA_NAT_SEQ_UNSPEC

This patch fixes an inconsistency in nfnetlink_conntrack.h that
I introduced myself. The problem is that CTA_NAT_SEQ_UNSPEC is
missing from enum ctattr_natseq. This inconsistency may lead to
problems in the message parsing in userspace (if the message
contains the CTA_NAT_SEQ_* attributes, of course).

This patch breaks backward compatibility, however, the only known
client of this code is libnetfilter_conntrack which indeed crashes
because it assumes the existence of CTA_NAT_SEQ_UNSPEC to do
the parsing.

The CTA_NAT_SEQ_* attributes were introduced in 2.6.25.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/netfilter/nfnetlink_conntrack.h