]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[PATCH] splice: fix bugs in pipe_to_file()
authorJens Axboe <axboe@suse.de>
Mon, 1 May 2006 17:50:48 +0000 (19:50 +0200)
committerJens Axboe <axboe@suse.de>
Mon, 1 May 2006 17:50:48 +0000 (19:50 +0200)
commit0568b409c74f7a125d92a09a3f386785700ef688
tree79125b2f4755e98949f0d941a0092e5d3367bbff
parent46e678c96bbd775abd05d3ddbe2fd334794f9157
[PATCH] splice: fix bugs in pipe_to_file()

Found by Oleg Nesterov <oleg@tv-sign.ru>, fixed by me.

- Only allow full pages to go to the page cache.
- Check page != buf->page instead of using PIPE_BUF_FLAG_STOLEN.
- Remember to clear 'stolen' if add_to_page_cache() fails.

And as a cleanup on that:

- Make the bottom fall-through logic a little less convoluted. Also make
  the steal path hold an extra reference to the page, so we don't have
  to differentiate between stolen and non-stolen at the end.

Signed-off-by: Jens Axboe <axboe@suse.de>
fs/pipe.c
fs/splice.c
include/linux/pipe_fs_i.h