]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
[TC]: oops in em_meta
authorStephen Hemminger <shemminger@vyatta.com>
Fri, 8 Feb 2008 02:13:00 +0000 (18:13 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 8 Feb 2008 02:13:00 +0000 (18:13 -0800)
commit04f217aca4d803fe72c2c54fe460d68f5233ce52
treea272e05b77afa50d868b08ce79daa22808aeef01
parent4e881a217bd1403960eb8f32297ba9d226c6d5ae
[TC]: oops in em_meta

If userspace passes a unknown match index into em_meta, then
em_meta_change will return an error and the data for the match will
not be set. This then causes an null pointer dereference when the
cleanup is done in the error path via tcf_em_tree_destroy. Since the
tree structure comes kzalloc, it is initialized to NULL.

Discovered when testing a new version of tc command against an
accidental older kernel.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/em_meta.c