]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
mxser: remove tty_port_tty_get from mxser_check_modem_status
authorJiri Slaby <jirislaby@gmail.com>
Mon, 6 Apr 2009 16:34:10 +0000 (17:34 +0100)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 6 Apr 2009 21:36:33 +0000 (14:36 -0700)
commit0326e6d596491db64d787136cbd703bde0ee8d77
tree4eca69db77dbfd32d1b59dc2239f65046c8aa3ae
parent0e0fd7d73ed130583dca16405b029f56bf65109f
mxser: remove tty_port_tty_get from mxser_check_modem_status

mxser_check_modem_status is called with tty parameter, so the
reference should be increased by callers already -- for ioctl
syscall it is held whole time gap since open to close, for
interrupt, the reference count is increased in the irq handler.

There is no tty_kref_put in that function, so this also fixes
a refcounting bug.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/char/mxser.c