]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
sched: fix a find_busiest_group buglet
authorPeter Zijlstra <a.p.zijlstra@chello.nl>
Fri, 24 Oct 2008 09:06:12 +0000 (11:06 +0200)
committerIngo Molnar <mingo@elte.hu>
Fri, 24 Oct 2008 10:50:59 +0000 (12:50 +0200)
commit01c8c57d668d94f1036d9ab11a22aa24ca16a35d
treea5bad4df146982e55bdd9dba73912f6bace036df
parent8c82a17e9c924c0e9f13e75e4c2f6bca19a4b516
sched: fix a find_busiest_group buglet

In one of the group load balancer patches:

commit 408ed066b11cf9ee4536573b4269ee3613bd735e
Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
Date:   Fri Jun 27 13:41:28 2008 +0200
Subject: sched: hierarchical load vs find_busiest_group

The following change:

-               if (max_load - this_load + SCHED_LOAD_SCALE_FUZZ >=
+               if (max_load - this_load + 2*busiest_load_per_task >=
                                        busiest_load_per_task * imbn) {

made the condition always true, because imbn is [1,2].
Therefore, remove the 2*, and give the it a fair chance.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Mike Galbraith <efault@gmx.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/sched.c