]> pilppa.com Git - linux-2.6-omap-h63xx.git/commit
UBI: don't use array index before testing if it is negative
authorJesper Juhl <jesper.juhl@gmail.com>
Fri, 3 Aug 2007 23:25:26 +0000 (01:25 +0200)
committerArtem Bityutskiy <Artem.Bityutskiy@nokia.com>
Sun, 14 Oct 2007 10:10:20 +0000 (13:10 +0300)
commit0169b49d52400a6035cd0f2ccd08bcba061a1a9b
tree534643ffe146db43ece0ce2476c2da919408bce5
parent8d2d4011f1398d984819c65043abb559c451a3c8
UBI: don't use array index before testing if it is negative

I can't find anything guaranteeing that 'ubi_num' cannot be <0 in
drivers/mtd/ubi/kapi.c::ubi_open_volume(), and in fact the code
even tests for that and errors out if so. Unfortunately the test
for "ubi_num < 0" happens after we've already used 'ubi_num' as
an array index - bad thing to do if it is negative.
This patch moves the test earlier in the function and then moves
the indexing using that variable after the check. A bit safer :-)

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
drivers/mtd/ubi/kapi.c